Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes for documentation build (issues #305, 307) #309

Merged
merged 5 commits into from
Apr 24, 2020
Merged

Bugfixes for documentation build (issues #305, 307) #309

merged 5 commits into from
Apr 24, 2020

Conversation

cattabiani
Copy link
Contributor

  • m2r & sphinx>=3.0 are not compatible (more info in pr in progress
    in m2r: [fix] TypeError coming from suffix arg removed from sphinx v3.0.0 miyakogi/m2r#55)
  • add path in conf.py to find the nmodl module
  • removed various doxygen warnings due to unacceptable keywords
    in configuration files
  • adjust checkparent_visitor sphinx autodoc /copybrief
  • reduce the maxium number of processors used to build documentation
    (it was freezing my workstation)

katta added 3 commits April 22, 2020 13:18
Bugfixes for documentation build (issues #305, 307)
c24348f 
- m2r & sphinx>=3.0 are not compatible (more info in pr in progress
  in m2r: miyakogi/m2r#55)
- add path in conf.py to find the nmodl module
- removed various doxygen warnings due to unacceptable keywords
  in configuration files
- adjust checkparent_visitor sphinx autodoc /copybrief
- reduce the maxium number of processors used to build documentation
  (it was freezing my workstation)
mistune downgrade because conflicting with nbconvert
b86de3b
fixup! Travis CI could not parse
a0845b1 
Comments can break travis CI parsing of .travis.yml
@cattabiani
Copy link
Contributor Author

please retest

1 similar comment
@cattabiani
Copy link
Contributor Author

please retest

@cattabiani cattabiani requested review from pramodk and ohm314 April 23, 2020 11:28
@cattabiani cattabiani self-assigned this Apr 23, 2020
ohm314
ohm314 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. just had one tiny suggestion

src/codegen/codegen_c_visitor.hpp Outdated Show resolved Hide resolved
@cattabiani
Update src/codegen/codegen_c_visitor.hpp
3b96520 
[string] is more understandable than "string" in comments without using <> since they mess up the documentation

Co-Authored-By: Omar Awile <[email protected]>
@cattabiani cattabiani merged commit 622fe58 into master Apr 24, 2020
@1uc 1uc deleted the issue_305_307 branch July 12, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohm314 ohm314 ohm314 approved these changes

@pramodk pramodk Awaiting requested review from pramodk

Assignees

@cattabiani cattabiani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cattabiani @ohm314